netdev - Re: [PATCH next] net/mlx5: make the symbol 'ESW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <846abf8c-8c81-a054-9f89-4ad56b104d99@mellanox.com>
Date:   Mon, 20 Jan 2020 14:33:01 +0000
From:   Paul Blakey <paulb@...lanox.com>
To:     Chen Wandun <chenwandun@...wei.com>, Oz Shlomo <ozsh@...lanox.com>,
        Mark Bloch <markb@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH next] net/mlx5: make the symbol 'ESW_POOLS' static


On 1/20/2020 2:41 PM, Chen Wandun wrote:
> Fix the following sparse warning:
> drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c:35:20: warning: symbol 'ESW_POOLS' was not declared. Should it be static?
>
> Fixes: 39ac237ce009 ("net/mlx5: E-Switch, Refactor chains and priorities")
> Signed-off-by: Chen Wandun <chenwandun@...wei.com>
> ---
>   .../ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> index 3a60eb5360bd..c5a446e295aa 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> @@ -32,10 +32,10 @@
>    * pools.
>    */
>   #define ESW_SIZE (16 * 1024 * 1024)
> -const unsigned int ESW_POOLS[] = { 4 * 1024 * 1024,
> -				   1 * 1024 * 1024,
> -				   64 * 1024,
> -				   4 * 1024, };
> +static const unsigned int ESW_POOLS[] = { 4 * 1024 * 1024,
> +					  1 * 1024 * 1024,
> +					  64 * 1024,
> +					  4 * 1024, };
>   
>   struct mlx5_esw_chains_priv {
>   	struct rhashtable chains_ht;

Acked-by: Paul Blakey <paulb@...lanox.com>