netdev - Re: [PATCH iproute2] ip: fix link type and vlan oneline output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200120093404.172208c2@hermes.lan>
Date:   Mon, 20 Jan 2020 09:34:04 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Vladis Dronov <vdronov@...hat.com>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>,
        George Shuklin <george.shuklin@...il.com>
Subject: Re: [PATCH iproute2] ip: fix link type and vlan oneline output

On Sun, 19 Jan 2020 02:12:51 +0100
Vladis Dronov <vdronov@...hat.com> wrote:

> Move link type printing in print_linkinfo() so multiline output does not
> break link options line. Add oneline support for vlan's ingress and egress
> qos maps.
> 
> Before the fix:
> 
> # ip -details link show veth90.4000
> 5: veth90.4000@...h90: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>     link/ether 26:9a:05:af:db:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535
>     vlan protocol 802.1Q id 4000 <REORDER_HDR>               the option line is broken ^^^
>       ingress-qos-map { 1:2 }
>       egress-qos-map { 2:1 } addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
> 
> # ip -oneline -details link show veth90.4000
> 5: veth90.4000@...h90: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000\    link/ether 26:9a:05:af:db:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535 \    vlan protocol 802.1Q id 4000 <REORDER_HDR>
>       ingress-qos-map { 1:2 }   <<< a multiline output despite -oneline
>       egress-qos-map { 2:1 } addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
> 
> After the fix:
> 
> # ip -details link show veth90.4000
> 5: veth90.4000@...h90: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>     link/ether 26:9a:05:af:db:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>     vlan protocol 802.1Q id 4000 <REORDER_HDR>
>       ingress-qos-map { 1:2 }
>       egress-qos-map { 2:1 }
> 
> # ip -oneline -details link show veth90.4000
> 5: veth90.4000@...h90: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000\    link/ether 26:9a:05:af:db:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 \    vlan protocol 802.1Q id 4000 <REORDER_HDR> \      ingress-qos-map { 1:2 } \      egress-qos-map { 2:1 }
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206241
> Reported-by: George Shuklin <george.shuklin@...il.com>
> Signed-off-by: Vladis Dronov <vdronov@...hat.com>

Applied with changes.
The change to ipaddress.c was incorrect. You can't change the order of things in the
output.

Second, you needed to have a Fixes tag. In this case, it went back to original
vlan support.