netdev - Re: [PATCH] tcp_bbr: improve arithmetic division in bbr_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af89b1c6-2182-be2e-6b44-1921483d426b@gmail.com>
Date:   Mon, 20 Jan 2020 09:58:23 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Wen Yang <wenyang@...ux.alibaba.com>,
        Eric Dumazet <edumazet@...gle.com>, davem@...emloft.net
Cc:     Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tcp_bbr: improve arithmetic division in bbr_update_bw()



On 1/20/20 2:04 AM, Wen Yang wrote:
> do_div() does a 64-by-32 division. Use div64_long() instead of it
> if the divisor is long, to avoid truncation to 32-bit.
> And as a nice side effect also cleans up the function a bit.
> 

Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Thanks !