lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jan 2020 10:35:56 -0800 From: Andrii Nakryiko <andrii.nakryiko@...il.com> To: Toke Høiland-Jørgensen <toke@...hat.com> Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>, Doug Ledford <dledford@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <brouer@...hat.com>, John Fastabend <john.fastabend@...il.com>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>, Shuah Khan <shuah@...nel.org>, Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, linux-rdma@...r.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, clang-built-linux@...glegroups.com Subject: Re: [PATCH bpf-next v4 04/10] tools/runqslower: Use consistent include paths for libbpf On Mon, Jan 20, 2020 at 4:57 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote: > > Andrii Nakryiko <andrii.nakryiko@...il.com> writes: > > > On Fri, Jan 17, 2020 at 5:37 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote: > >> > >> From: Toke Høiland-Jørgensen <toke@...hat.com> > >> > >> Fix the runqslower tool to include libbpf header files with the bpf/ > >> prefix, to be consistent with external users of the library. Also ensure > >> that all includes of exported libbpf header files (those that are exported > >> on 'make install' of the library) use bracketed includes instead of quoted. > >> > >> To not break the build, keep the old include path until everything has been > >> changed to the new one; a subsequent patch will remove that. > >> > >> Fixes: 6910d7d3867a ("selftests/bpf: Ensure bpf_helper_defs.h are taken from selftests dir") > >> Acked-by: Andrii Nakryiko <andriin@...com> > >> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com> > >> --- > >> tools/bpf/runqslower/Makefile | 5 +++-- > >> tools/bpf/runqslower/runqslower.bpf.c | 2 +- > >> tools/bpf/runqslower/runqslower.c | 4 ++-- > >> 3 files changed, 6 insertions(+), 5 deletions(-) > >> > >> diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile > >> index b62fc9646c39..9f022f7f2593 100644 > >> --- a/tools/bpf/runqslower/Makefile > >> +++ b/tools/bpf/runqslower/Makefile > >> @@ -5,6 +5,7 @@ LLC := llc > >> LLVM_STRIP := llvm-strip > >> DEFAULT_BPFTOOL := $(OUTPUT)/sbin/bpftool > >> BPFTOOL ?= $(DEFAULT_BPFTOOL) > >> +INCLUDES := -I$(OUTPUT) -I$(abspath ../../lib) -I$(abspath ../../lib/bpf) > >> LIBBPF_SRC := $(abspath ../../lib/bpf) > > > > drop LIBBPF_SRC, it's not used anymore > > It is: in the rule for building libbpf there's a '-C $(LIBBPF_SRC)' > Ah, right, missed that one. Looked a bit weird to have $(abspath ../../lib/bpf) used in INCLUDES and then separate LIBBPF_SRC definition there, maybe LIBBPF_SRC := $(abspath ../../lib/bpf) INCLUDES := -I$(OUTPUT) -I$(abspath ../../lib) -I$(LIBBPF_SRC) > -Toke >
Powered by blists - more mailing lists