lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 20 Jan 2020 22:11:31 +0100
From:   Daniel Borkmann <>
To:     Matt Cover <>,
        John Fastabend <>
Cc:     Alexei Starovoitov <>,
        Martin KaFai Lau <>,
        Song Liu <>, Yonghong Song <>,
        Andrii Nakryiko <>,
        "David S. Miller" <>,
        Shuah Khan <>,
        Jakub Kicinski <>,
        Jesper Dangaard Brouer <>,
        Jakub Sitnicki <>,
        Quentin Monnet <>,
        Matthew Cover <>,
        Stanislav Fomichev <>,
        Andrey Ignatov <>,
        Lorenz Bauer <>,
        Jiong Wang <>,,,,
Subject: Re: [PATCH bpf-next] bpf: add bpf_ct_lookup_{tcp,udp}() helpers

On 1/20/20 9:10 PM, Matt Cover wrote:
> On Mon, Jan 20, 2020 at 11:11 AM Matt Cover <> wrote:
>> On Sat, Jan 18, 2020 at 8:05 PM John Fastabend <> wrote:
>>> Matthew Cover wrote:
>>>> Allow looking up an nf_conn. This allows eBPF programs to leverage
>>>> nf_conntrack state for similar purposes to socket state use cases,
>>>> as provided by the socket lookup helpers. This is particularly
>>>> useful when nf_conntrack state is locally available, but socket
>>>> state is not.
>>>> Signed-off-by: Matthew Cover <>
>>>> ---
>>> Couple coding comments below. Also looks like a couple build errors
>>> so fix those up. I'm still thinking over this though.
>> Thank you for taking the time to look this over. I will be looking
>> into the build issues.
> Looks like I missed static inline on a couple functions when
> nf_conntrack isn't builtin. I'll include the fix in v2.

One of the big issues I'd see with this integration is that literally no-one
will be able to use it unless they manually recompile their distro kernel with
ct as builtin instead of module .. Have you considered writing a tcp/udp ct in
plain bpf? Perhaps would make sense to have some sort of tools/lib/bpf/util/
with bpf prog library code that can be included.

Powered by blists - more mailing lists