netdev - Re: [PATCH net-next 1/3] vsock: add network namespace support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200120.100610.546818167633238909.davem@davemloft.net>
Date:   Mon, 20 Jan 2020 10:06:10 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     sgarzare@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        jhansen@...are.com, jasowang@...hat.com, kvm@...r.kernel.org,
        stefanha@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-hyperv@...r.kernel.org, mst@...hat.com, decui@...rosoft.com
Subject: Re: [PATCH net-next 1/3] vsock: add network namespace support

From: Stefano Garzarella <sgarzare@...hat.com>
Date: Thu, 16 Jan 2020 18:24:26 +0100

> This patch adds 'netns' module param to enable this new feature
> (disabled by default), because it changes vsock's behavior with
> network namespaces and could break existing applications.

Sorry, no.

I wonder if you can even design a legitimate, reasonable, use case
where these netns changes could break things.

I am totally against adding a module parameter for this, it's
incredibly confusing for users and will create a test scenerio
that is strongly less likely to be covered.