netdev - Re: [PATCH net-next] devlink: Add health recover notifications on devlink flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ed99e52-f55f-0a4a-0eb0-974504bed85a@mellanox.com>
Date:   Mon, 20 Jan 2020 12:08:22 +0000
From:   Moshe Shemesh <moshe@...lanox.com>
To:     David Miller <davem@...emloft.net>
CC:     Jiri Pirko <jiri@...lanox.com>,
        "vikas.gupta@...adcom.com" <vikas.gupta@...adcom.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] devlink: Add health recover notifications on
 devlink flows


On 1/20/2020 11:50 AM, David Miller wrote:
> From: Moshe Shemesh <moshe@...lanox.com>
> Date: Sun, 19 Jan 2020 17:04:28 +0200
>
>> Devlink health recover notifications were added only on driver direct
>> updates of health_state through devlink_health_reporter_state_update().
>> Add notifications on updates of health_state by devlink flows of report
>> and recover.
>>
>> Fixes: 97ff3bd37fac ("devlink: add devink notification when reporter update health state")
>> Signed-off-by: Moshe Shemesh <moshe@...lanox.com>
>> Acked-by: Jiri Pirko <jiri@...lanox.com>
> I really dislike forward declarations and almost all of the time they are
> unnecessary.
>
> Could you please just rearrange the code as needed and resubmit?
Sure, I will resubmit.
> Thank you.