netdev - Re: [PATCH] hsr: Fix a compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMArcTW6YXKjDnxq4bgqQM6aL=ZZ2u+SNVs+NXoA-HSLxaq16g@mail.gmail.com>
Date:   Mon, 20 Jan 2020 13:44:56 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     "xiaofeng.yan" <xiaofeng.yan2012@...il.com>
Cc:     arvid.brodin@...en.se, David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, yanxiaofeng7@...com
Subject: Re: [PATCH] hsr: Fix a compilation error

On Mon, 20 Jan 2020 at 12:26, xiaofeng.yan <xiaofeng.yan2012@...il.com> wrote:
>
> From: "xiaofeng.yan" <yanxiaofeng7@...com>
>

Hi Xiaofeng,

> A compliation error happen when building branch 5.5-rc7
>
> In file included from net/hsr/hsr_main.c:12:0:
> net/hsr/hsr_main.h:194:20: error: two or more data types in declaration specifiers
>  static inline void void hsr_debugfs_rename(struct net_device *dev)
>
> So Removed one void.
>
> Signed-off-by: xiaofeng.yan <yanxiaofeng7@...com>

Acked-by: Taehee Yoo <ap420073@...il.com>

I think the Fixes tag is needed.
You might have to send a v2 patch, which includes this Fixes tag.
Fixes: 4c2d5e33dcd3 ("hsr: rename debugfs file when interface name is changed")

Thank you!
Taehee Yoo