netdev - RE: [PATCH net 2/9] r8152: reset flow control patch when linking on for RTL8153B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jan 2020 13:19:19 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Joe Perches <joe@...ches.com>, David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "pmalani@...omium.org" <pmalani@...omium.org>,
        "grundler@...omium.org" <grundler@...omium.org>
Subject: RE: [PATCH net 2/9] r8152: reset flow control patch when linking on for RTL8153B

Joe Perches [mailto:joe@...ches.com]
> Sent: Tuesday, January 21, 2020 9:01 PM
> To: David Miller; Hayes Wang
[...]
> > >  static int rtl8153_enable(struct r8152 *tp)
> > >  {
> > > +     u32 ocp_data;
> > >       if (test_bit(RTL8152_UNPLUG, &tp->flags))
> > >               return -ENODEV;
> > >
> >
> > Please put an empty line after the local variable declarations.
> 
> Local scoping is generally better.
> 
> Perhaps declare ocp_data inside the if branch
> where it's used.

OK. I would move it.

Best Regards,
Hayes