netdev - Re: [PATCH v2] net, ip_tunnel: fix namespaces move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Jan 2020 15:30:45 +0000
From:   William Dauchy <w.dauchy@...teo.com>
To:     David Miller <davem@...emloft.net>
CC:     William Dauchy <w.dauchy@...teo.com>,
        NETDEV <netdev@...r.kernel.org>,
        Pravin B Shelar <pshelar@...ira.com>,
        William Tu <u9012063@...il.com>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH v2] net, ip_tunnel: fix namespaces move

Hi David,

On Tue, Jan 21, 2020 at 4:07 PM David Miller <davem@...emloft.net> wrote:
> From: William Dauchy <w.dauchy@...teo.com>
> Date: Tue, 21 Jan 2020 15:26:24 +0100
>
> > in the same manner as commit 690afc165bb3 ("net: ip6_gre: fix moving
> > ip6gre between namespaces"), fix namespace moving as it was broken since
> > commit 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.").
> > Indeed, the ip6_gre commit removed the local flag for collect_md
> > condition, so there is no reason to keep it for ip_gre/ip_tunnel.
> >
> > this patch will fix both ip_tunnel and ip_gre modules.
> >
> > Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.")
> > Signed-off-by: William Dauchy <w.dauchy@...teo.com>
>
> Applied and queued up for -stable, thanks.

As discussed in this thread, we should probably queue up
commit 690afc165bb3 ("net: ip6_gre: fix moving ip6gre between namespaces")
"Fixes" was forgotten; it was fixing commit 6712abc168eb ("ip6_gre:
add ip6 gre and gretap collect_md mode")

Best,
-- 
William