netdev - Re: [PATCH v4 04/17] octeontx2-pf: Initialize and config queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200121080058.42b0c473@cakuba>
Date:   Tue, 21 Jan 2020 08:00:58 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mkubecek@...e.cz,
        Sunil Goutham <sgoutham@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>
Subject: Re: [PATCH v4 04/17] octeontx2-pf: Initialize and config queues

On Tue, 21 Jan 2020 18:51:38 +0530, sunil.kovvuri@...il.com wrote:
> +dma_addr_t otx2_alloc_rbuf(struct otx2_nic *pfvf, struct otx2_pool *pool,
> +			   gfp_t gfp)
> +{
> +	dma_addr_t iova;
> +
> +	/* Check if request can be accommodated in previous allocated page */
> +	if (pool->page &&
> +	    ((pool->page_offset + pool->rbsize) <= PAGE_SIZE)) {
> +		pool->pageref++;
> +		goto ret;
> +	}
> +
> +	otx2_get_page(pool);
> +
> +	/* Allocate a new page */
> +	pool->page = alloc_pages(gfp | __GFP_COMP | __GFP_NOWARN,
> +				 pool->rbpage_order);
> +	if (unlikely(!pool->page))
> +		return -ENOMEM;
> +
> +	pool->page_offset = 0;
> +ret:
> +	iova = (u64)otx2_dma_map_page(pfvf, pool->page, pool->page_offset,
> +				      pool->rbsize, DMA_FROM_DEVICE);
> +	if (!iova) {
> +		if (!pool->page_offset)
> +			__free_pages(pool->page, pool->rbpage_order);
> +		pool->page = NULL;
> +		return -ENOMEM;
> +	}
> +	pool->page_offset += pool->rbsize;
> +	return iova;
> +}

You don't seem to be doing any page recycling if I'm reading this right.
Can't you use the standard in-kernel page frag allocator
(netdev_alloc_frag/napi_alloc_frag)?