netdev - RE: [PATCH v2 bpf-next 3/3] selftests/bpf: Add tests for program extensions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e2745bccbf37_74b42ad14ee465c044@john-XPS-13-9370.notmuch>
Date:   Tue, 21 Jan 2020 10:41:00 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Alexei Starovoitov <ast@...nel.org>, davem@...emloft.net
Cc:     daniel@...earbox.net, netdev@...r.kernel.org, bpf@...r.kernel.org,
        kernel-team@...com
Subject: RE: [PATCH v2 bpf-next 3/3] selftests/bpf: Add tests for program
 extensions

Alexei Starovoitov wrote:
> Add program extension tests that build on top of fexit_bpf2bpf tests.
> Replace three global functions in previously loaded test_pkt_access.c program
> with three new implementations:
> int get_skb_len(struct __sk_buff *skb);
> int get_constant(long val);
> int get_skb_ifindex(int val, struct __sk_buff *skb, int var);
> New function return the same results as original only if arguments match.
> 
> new_get_skb_ifindex() demonstrates that 'skb' argument doesn't have to be first
> and only argument of BPF program. All normal skb based accesses are available.
> 
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> ---
>  .../selftests/bpf/prog_tests/fexit_bpf2bpf.c  | 20 ++++++-
>  .../selftests/bpf/progs/fexit_bpf2bpf.c       | 57 +++++++++++++++++++
>  .../selftests/bpf/progs/test_pkt_access.c     |  8 ++-
>  3 files changed, 83 insertions(+), 2 deletions(-)

Acked-by: John Fastabend <john.fastabend@...il.com>