netdev - Re: [PATCH] net/mlx5e: Fix printk format warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <028a4905eaf02dce476e8cfc517b49760f57f577.camel@mellanox.com>
Date:   Tue, 21 Jan 2020 20:43:18 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "saeedm@....mellanox.co.il" <saeedm@....mellanox.co.il>,
        "olof@...om.net" <olof@...om.net>
CC:     "joe@...ches.com" <joe@...ches.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "leon@...nel.org" <leon@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/mlx5e: Fix printk format warning

On Mon, 2020-01-20 at 19:20 -0800, Olof Johansson wrote:
> Hi,
> 
> On Mon, Dec 30, 2019 at 8:35 PM Saeed Mahameed
> <saeedm@....mellanox.co.il> wrote:
> > On Sat, Dec 21, 2019 at 1:19 PM Olof Johansson <olof@...om.net>
> > wrote:
> > > On Thu, Dec 19, 2019 at 6:07 PM Joe Perches <joe@...ches.com>
> > > wrote:
> > > > On Thu, 2019-12-19 at 16:15 -0800, Olof Johansson wrote:
> > > > > Use "%zu" for size_t. Seen on ARM allmodconfig:
> > > > []
> > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.c
> > > > > b/drivers/net/ethernet/mellanox/mlx5/core/wq.c
> > > > []
> > > > > @@ -89,7 +89,7 @@ void mlx5_wq_cyc_wqe_dump(struct
> > > > > mlx5_wq_cyc *wq, u16 ix, u8 nstrides)
> > > > >       len = nstrides << wq->fbc.log_stride;
> > > > >       wqe = mlx5_wq_cyc_get_wqe(wq, ix);
> > > > > 
> > > > > -     pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index
> > > > > 0x%x, len: %ld\n",
> > > > > +     pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index
> > > > > 0x%x, len: %zu\n",
> > > > >               mlx5_wq_cyc_get_size(wq), wq->cur_sz, ix, len);
> > > > >       print_hex_dump(KERN_WARNING, "", DUMP_PREFIX_OFFSET,
> > > > > 16, 1, wqe, len, false);
> > > > >  }
> > > > 
> > > > One might expect these 2 outputs to be at the same KERN_<LEVEL>
> > > > too.
> > > > One is KERN_INFO the other KERN_WARNING
> > > 
> > > Sure, but I'll leave that up to the driver maintainers to
> > > decide/fix
> > > -- I'm just addressing the type warning here.
> > 
> > Hi Olof, sorry for the delay, and thanks for the patch,
> > 
> > I will apply this to net-next-mlx5 and will submit to net-next
> > myself.
> > we will fixup and address the warning level comment by Joe.
> 
> This seems to still be pending, and the merge window is soon here.
> Any
> chance we can see it show up in linux-next soon?
> 
> 

Hi Olof,

I am still preparing my next pull request which will include this patch
I will send it soon to net-next branch, but still the patch will not
hit linux-next until the merge window when netdev subsystem is pulled
into linux-next..

Thanks,
Saeed.