netdev - RE: [PATCH bpf-next] xsk, net: make sock_def

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e264a3a5d5e6_20912afc5c86e5c4b5@john-XPS-13-9370.notmuch>
Date:   Mon, 20 Jan 2020 16:47:54 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Björn Töpel <bjorn.topel@...il.com>,
        netdev@...r.kernel.org, ast@...nel.org, daniel@...earbox.net
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        bpf@...r.kernel.org, magnus.karlsson@...el.com,
        jonathan.lemon@...il.com
Subject: RE: [PATCH bpf-next] xsk, net: make sock_def_readable() have external
 linkage

Björn Töpel wrote:
> From: Björn Töpel <bjorn.topel@...el.com>
> 
> XDP sockets use the default implementation of struct sock's
> sk_data_ready callback, which is sock_def_readable(). This function is
> called in the XDP socket fast-path, and involves a retpoline. By
> letting sock_def_readable() have external linkage, and being called
> directly, the retpoline can be avoided.
> 
> Signed-off-by: Björn Töpel <bjorn.topel@...el.com>
> ---
>  include/net/sock.h | 2 ++
>  net/core/sock.c    | 2 +-
>  net/xdp/xsk.c      | 2 +-
>  3 files changed, 4 insertions(+), 2 deletions(-)
> 

I think this is fine but curious were you able to measure the
difference with before/after pps or something?