lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Jan 2020 16:54:15 +0800 From: Chen Zhou <chenzhou10@...wei.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, <davem@...emloft.net>, <mhabets@...arflare.com>, <kuba@...nel.org> CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0 Hi Sergei, On 2020/1/21 16:39, Sergei Shtylyov wrote: > Hello! > > On 21.01.2020 4:35, Chen Zhou wrote: > >> Fixes coccicheck warning: >> >> ./drivers/net/ethernet/amd/declance.c:611:14-15: >> WARNING comparing pointer to 0 >> >> Compare pointer-typed values to NULL rather than 0. > > I don't see NULL in the patch -- you used ! instead. Yeah, i used ! here. Thanks, Chen Zhou > >> Signed-off-by: Chen Zhou <chenzhou10@...wei.com> >> --- >> drivers/net/ethernet/amd/declance.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c >> index 6592a2d..7282ce5 100644 >> --- a/drivers/net/ethernet/amd/declance.c >> +++ b/drivers/net/ethernet/amd/declance.c >> @@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev) >> len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4; >> skb = netdev_alloc_skb(dev, len + 2); >> - if (skb == 0) { >> + if (!skb) { >> dev->stats.rx_dropped++; >> *rds_ptr(rd, mblength, lp->type) = 0; >> *rds_ptr(rd, rmd1, lp->type) = > > MBR, Sergei > >
Powered by blists - more mailing lists