netdev - Re: [PATCH net] ipv6: sr: remove SKB_GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200121.101908.1503286381717753243.davem@davemloft.net>
Date:   Tue, 21 Jan 2020 10:19:08 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     tagyounit@...il.com
Cc:     netdev@...r.kernel.org, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, dlebrun@...gle.com,
        david.lebrun@...ouvain.be
Subject: Re: [PATCH net] ipv6: sr: remove SKB_GSO_IPXIP6 on End.D* actions

From: Yuki Taguchi <tagyounit@...il.com>
Date: Mon, 20 Jan 2020 13:48:37 +0900

> After LRO/GRO is applied, SRv6 encapsulated packets have
> SKB_GSO_IPXIP6 feature flag, and this flag must be removed right after
> decapulation procedure.
> 
> Currently, SKB_GSO_IPXIP6 flag is not removed on End.D* actions, which
> creates inconsistent packet state, that is, a normal TCP/IP packets
> have the SKB_GSO_IPXIP6 flag. This behavior can cause unexpected
> fallback to GSO on routing to netdevices that do not support
> SKB_GSO_IPXIP6. For example, on inter-VRF forwarding, decapsulated
> packets separated into small packets by GSO because VRF devices do not
> support TSO for packets with SKB_GSO_IPXIP6 flag, and this degrades
> forwarding performance.
> 
> This patch removes encapsulation related GSO flags from the skb right
> after the End.D* action is applied.
> 
> Fixes: d7a669dd2f8b ("ipv6: sr: add helper functions for seg6local")
> Signed-off-by: Yuki Taguchi <tagyounit@...il.com>

Applied and queued up for -stable, thanks.