netdev - Re: [PATCH net-next v2] net/mlx5e: Don't allow forwarding between uplink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMiiYaJ0QorDyKqpo6cpfhQ1k9HV3z=4=5FpB_q9h4ffOA@mail.gmail.com>
Date:   Tue, 21 Jan 2020 11:49:25 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Roi Dayan <roid@...lanox.com>
Cc:     "xiangxia.m.yue@...il.com" <xiangxia.m.yue@...il.com>,
        "saeedm@....mellanox.co.il" <saeedm@....mellanox.co.il>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2] net/mlx5e: Don't allow forwarding between uplink

On Tue, Jan 21, 2020 at 11:39 AM Roi Dayan <roid@...lanox.com> wrote:
> On 2020-01-19 4:25 AM, xiangxia.m.yue@...il.com wrote:

> I noticed you still modified mlx5e_is_valid_eswitch_fwd_dev() which
> is called from parse tc actions and also from resolving route for vxlan rules.
>
> I tested the patch for normal, lag and ecmp modes.
> ecmp vxlan encap rule breaks now as not supported.
> the break is in get_route_and_out_devs() at this part
>
> else if (mlx5e_eswitch_rep(dev) &&
>                  mlx5e_is_valid_eswitch_fwd_dev(priv, dev))
>
> since ecmp is like lag we fail on the same scenario here that
> we test uplink priv but not input vport.

Guys,

I thought we agreed to hold on with blocking this in the driver -
should 1st see that the FW is fixed.