netdev - Re: [PATCH] devlink: Add enable_ecn boolean generic parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jan 2020 14:32:19 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Pavan Chebbi <pavan.chebbi@...adcom.com>
Cc:     davem@...emloft.net, michael.chan@...adcom.com,
        vasundhara-v.volam@...adcom.com, netdev@...r.kernel.org,
        jiri@...lanox.com
Subject: Re: [PATCH] devlink: Add enable_ecn boolean generic parameter

Wed, Jan 22, 2020 at 11:40:46AM CET, pavan.chebbi@...adcom.com wrote:
>enable_ecn - Enables Explicit Congestion Notification
>characteristic of the device.
>
>Cc: Jiri Pirko <jiri@...lanox.com>
>Signed-off-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

NAK.

You are missing at least:
documentation
driver user


>---
> include/net/devlink.h | 4 ++++
> net/core/devlink.c    | 5 +++++
> 2 files changed, 9 insertions(+)
>
>diff --git a/include/net/devlink.h b/include/net/devlink.h
>index 5e46c24..52315dd 100644
>--- a/include/net/devlink.h
>+++ b/include/net/devlink.h
>@@ -403,6 +403,7 @@ enum devlink_param_generic_id {
> 	DEVLINK_PARAM_GENERIC_ID_FW_LOAD_POLICY,
> 	DEVLINK_PARAM_GENERIC_ID_RESET_DEV_ON_DRV_PROBE,
> 	DEVLINK_PARAM_GENERIC_ID_ENABLE_ROCE,
>+	DEVLINK_PARAM_GENERIC_ID_ENABLE_ECN,
> 
> 	/* add new param generic ids above here*/
> 	__DEVLINK_PARAM_GENERIC_ID_MAX,
>@@ -440,6 +441,9 @@ enum devlink_param_generic_id {
> #define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME "enable_roce"
> #define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE DEVLINK_PARAM_TYPE_BOOL
> 
>+#define DEVLINK_PARAM_GENERIC_ENABLE_ECN_NAME "enable_ecn"
>+#define DEVLINK_PARAM_GENERIC_ENABLE_ECN_TYPE DEVLINK_PARAM_TYPE_BOOL
>+
> #define DEVLINK_PARAM_GENERIC(_id, _cmodes, _get, _set, _validate)	\
> {									\
> 	.id = DEVLINK_PARAM_GENERIC_ID_##_id,				\
>diff --git a/net/core/devlink.c b/net/core/devlink.c
>index 64367ee..298dcd1 100644
>--- a/net/core/devlink.c
>+++ b/net/core/devlink.c
>@@ -3011,6 +3011,11 @@ static int devlink_nl_cmd_flash_update(struct sk_buff *skb,
> 		.name = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME,
> 		.type = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE,
> 	},
>+	{
>+		.id = DEVLINK_PARAM_GENERIC_ID_ENABLE_ECN,
>+		.name = DEVLINK_PARAM_GENERIC_ENABLE_ECN_NAME,
>+		.type = DEVLINK_PARAM_GENERIC_ENABLE_ECN_TYPE,
>+	},
> };
> 
> static int devlink_param_generic_verify(const struct devlink_param *param)
>-- 
>1.8.3.1
>