netdev - Re: [PATCH net-next v6 10/10] net: sched: add Flow Queue PIE packet scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADAms0ync3s6sOtH5ywwC6yWAK9P73d6+D+FqhtvUMyBwSVqEQ@mail.gmail.com>
Date:   Wed, 22 Jan 2020 23:10:10 +0530
From:   Gautam Ramakrishnan <gautamramk@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "Mohit P. Tahiliani" <tahiliani@...k.edu.in>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        "David S . Miller" <davem@...emloft.net>,
        Dave Taht <dave.taht@...il.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Leslie Monis <lesliemonis@...il.com>,
        "Sachin D . Patil" <sdp.sachin@...il.com>,
        "V . Saicharan" <vsaicharan1998@...il.com>,
        Mohit Bhasi <mohitbhasi1998@...il.com>
Subject: Re: [PATCH net-next v6 10/10] net: sched: add Flow Queue PIE packet scheduler

On Wed, Jan 22, 2020 at 9:12 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 22 Jan 2020 17:05:33 +0530, gautamramk@...il.com wrote:
> > +     err = tcf_block_get(&q->block, &q->filter_list, sch, extack);
> > +     if (err)
> > +             goto init_failure;
>
> I think you're missing a tcf_block_put() call or equivalent.
Thanks for pointing it out. I shall make the change and resubmit.


-- 
-------------
Gautam |