netdev - Re: [PATCH net-next v2] net/mlx5e: Add mlx5e_flower_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jan 2020 19:17:08 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "wenxu@...oud.cn" <wenxu@...oud.cn>, Roi Dayan <roid@...lanox.com>,
        Mark Bloch <markb@...lanox.com>,
        Paul Blakey <paulb@...lanox.com>,
        Vlad Buslov <vladbu@...lanox.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2] net/mlx5e: Add mlx5e_flower_parse_meta
 support

On Wed, 2020-01-22 at 08:50 +0000, Roi Dayan wrote:
> 
> On 2020-01-21 10:56 PM, Saeed Mahameed wrote:
> > On Wed, 2020-01-15 at 08:51 +0000, Roi Dayan wrote:
> > > On 2020-01-15 1:58 AM, wenxu wrote:
> > > >  2020/1/15 4:46, Saeed Mahameed :
> > > > > Hi Wenxu,
> > > > > 
> > > > > According to our regression Team, This commit is breaking
> > > > > vxlan
> > > > > offload
> > > > > CC'ed Paul, Roi and Vlad, they will assist you if you need
> > > > > any
> > > > > help.
> > > > > 
> > > > > can you please investigate the following call trace ?
> > > > 
> > > > Hi Saeed & Paul,
> > > > 
> > > > 
> > > > This patch just check the meta key match with the
> > > > filter_dev.  If
> > > > this match failed,
> > > > 
> > > > The new flower install will failed and never allocate new
> > > > mlx5_fs_ftes.
> > > > 
> > > > How can I reproduce this case? Can you provide the test case
> > > > script?
> > > > 
> > > > 
> > > > BR
> > > > 
> > > > wenxu
> > > 
> > > Hi Saeed, Wenxu,
> > > 
> > > I reviewed the patch and verified manually just in case. Such
> > > issue
> > > should
> > > not be reproduced from this patch and indeed I did not reproduce
> > > it.
> > > I'll take the issue with our regression team.
> > > I acked the patch. looks good to me.
> > > 
> > > Thanks,
> > > Roi
> > > 
> > > 
> > 
> > Thanks Roi, 
> > 
> > If the discussion is over and you ack the patch, please provide a
> > formal "Acked-by" tag so i will pull this patch into net-next-mlx5.
> > 
> > Thanks,
> > Saeed.
> > 
> 
> I thought I did. sorry.
> 
> Acked-by: Roi Dayan <roid@...lanox.com>

Applied to net-next-mlx5,

Thanks!