netdev - Re: [PATCH] net-core: remove unnecessary ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200122234753.GA13647@lunn.ch>
Date:   Thu, 23 Jan 2020 00:47:53 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Luigi Rizzo <lrizzo@...gle.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [PATCH] net-core: remove unnecessary ETHTOOL_GCHANNELS
 initialization

On Wed, Jan 22, 2020 at 02:33:26PM -0800, Luigi Rizzo wrote:
> struct ethtool_channels does not need .cmd to be set when calling the
> driver's ethtool methods. Just zero-initialize it.
> 
> Tested: run ethtool -l and ethtool -L

Hi Luigi

This seems pretty risky. You are assuming ethtool is the only user of
this API. What is actually wrong with putting a sane cmd value, rather
than the undefined value 0.

     Andrew