netdev - Re: [PATCH bpf-next] bpf: Fix error path under memory pressure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <FD587CC6-F007-4CF9-BECC-6344586EC8A5@fb.com>
Date:   Wed, 22 Jan 2020 06:56:19 +0000
From:   Song Liu <songliubraving@...com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
CC:     Alexei Starovoitov <ast@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        "Network Development" <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next] bpf: Fix error path under memory pressure



> On Jan 21, 2020, at 6:45 PM, Alexei Starovoitov <alexei.starovoitov@...il.com> wrote:
> 
> On Tue, Jan 21, 2020 at 6:42 PM Alexei Starovoitov <ast@...nel.org> wrote:
>> 
>> Restore the 'if (env->cur_state)' check that was incorrectly removed during
>> code move. Under memory pressure env->cur_state can be freed and zeroed inside
>> do_check(). Hence the check is necessary.
>> 
>> Fixes: 51c39bb1d5d1 ("bpf: Introduce function-by-function verification")
>> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> 
> Forgot to add:
> Reported-by: syzbot+b296579ba5015704d9fa@...kaller.appspotmail.com
> 
> Daniel, pls add while applying.

Acked-by: Song Liu <songliubraving@...com>

Thanks for the fix!