netdev - Re: [PATCH net-next 01/14] qed: FW 8.42.2.0 Internal ram offsets modifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200123062606.728b838b@cakuba>
Date:   Thu, 23 Jan 2020 06:26:06 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michal Kalderon <mkalderon@...vell.com>
Cc:     Ariel Elior <aelior@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH net-next 01/14] qed: FW 8.42.2.0 Internal ram offsets
 modifications

On Wed, 22 Jan 2020 16:02:06 +0000, Michal Kalderon wrote:
> > From: linux-rdma-owner@...r.kernel.org <linux-rdma-  
> > owner@...r.kernel.org> On Behalf Of Jakub Kicinski  
> > 
> > On Wed, 22 Jan 2020 17:26:14 +0200, Michal Kalderon wrote:  
> > > IRO stands for internal RAM offsets. Updating the FW binary produces
> > > different iro offsets. This file contains the different values, and a
> > > new representation of the values.
> > >
> > > Signed-off-by: Ariel Elior <ariel.elior@...vell.com>
> > > Signed-off-by: Michal Kalderon <michal.kalderon@...vell.com>  
> > 
> > If you have different offsets depending on FW build - where is the code that
> > checks the FW version is the one driver expects? At a quick glance you're not
> > bumping any numbers in this patch..  
> The FW version is bumped in patch 0009-qed-FW-8.42.2.0-HSI-Changes.patch and the driver loads
> The FW binary according to this version. 

Please make it so the driver is not broken between patch 1 and patch 9.