netdev - [PATCH] net: stmmac: platform: fix probe for ACPI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200123011635.15137-1-ajayg@nvidia.com>
Date:   Wed, 22 Jan 2020 17:16:35 -0800
From:   Ajay Gupta <ajaykuee@...il.com>
To:     davem@...emloft.net, mcoquelin.stm32@...il.com
Cc:     netdev@...r.kernel.org, joabreu@...opsys.com,
        peppe.cavallaro@...com, alexandre.torgue@...com,
        Ajay Gupta <ajayg@...dia.com>
Subject: [PATCH] net: stmmac: platform: fix probe for ACPI devices

From: Ajay Gupta <ajayg@...dia.com>

Use generic device API to get phy mode to fix probe failure
with ACPI based devices.

Signed-off-by: Ajay Gupta <ajayg@...dia.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 4775f49d7f3b..d10ac54bf385 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -412,9 +412,9 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
 		*mac = NULL;
 	}
 
-	rc = of_get_phy_mode(np, &plat->phy_interface);
-	if (rc)
-		return ERR_PTR(rc);
+	plat->phy_interface = device_get_phy_mode(&pdev->dev);
+	if (plat->phy_interface < 0)
+		return ERR_PTR(plat->phy_interface);
 
 	plat->interface = stmmac_of_get_mac_mode(np);
 	if (plat->interface < 0)
-- 
2.17.1