netdev - Re: [PATCH] net-core: remove unnecessary ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200123200106.GU22304@unicorn.suse.cz>
Date:   Thu, 23 Jan 2020 21:01:06 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     netdev@...r.kernel.org
Cc:     Luigi Rizzo <lrizzo@...gle.com>, Andrew Lunn <andrew@...n.ch>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net-core: remove unnecessary ETHTOOL_GCHANNELS
 initialization

On Thu, Jan 23, 2020 at 09:47:56AM -0800, Luigi Rizzo wrote:
> 
> For the same reason though (comply with the header) we might perhaps
> want to replace with cmd with ETHTOOL_SCHANNELS before actually
> calling dev->ethtool_ops->set_channels()
> 
> (I realize this is not particularly important)

That structure is filled by copy_from_user() and the structure passed by
userspace already has .cmd = ETHTOOL_SCHANNELS - otherwise we wouldn't
end up in ethtool_set_channels().

Michal