netdev - Re: [PATCH net] net: rtnetlink: validate IFLA_MTU attribute in rtnl_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200123.111601.254361683807540052.davem@davemloft.net>
Date:   Thu, 23 Jan 2020 11:16:01 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net] net: rtnetlink: validate IFLA_MTU attribute in
 rtnl_create_link()

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue, 21 Jan 2020 22:47:29 -0800

> rtnl_create_link() needs to apply dev->min_mtu and dev->max_mtu
> checks that we apply in do_setlink()
> 
> Otherwise malicious users can crash the kernel, for example after
> an integer overflow :
 ...
> Fixes: 61e84623ace3 ("net: centralize net_device min/max MTU checking")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable, thanks Eric.