netdev - Re: [PATCH net-next] netlink: make getters tolerate NULL nla arg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202001242350.Qz0yYr27%lkp@intel.com>
Date:   Fri, 24 Jan 2020 23:47:07 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Florian Westphal <fw@...len.de>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        Florian Westphal <fw@...len.de>
Subject: Re: [PATCH net-next] netlink: make getters tolerate NULL nla arg

Hi Florian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master ipvs/master v5.5-rc7 next-20200124]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/netlink-make-getters-tolerate-NULL-nla-arg/20200117-200009
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 6bc8038035267d12df2bf78a8e1a5f07069fabb8
config: x86_64-randconfig-a001-20200124 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/net/rtnetlink.h:6:0,
                    from include/net/sch_generic.h:20,
                    from include/linux/filter.h:25,
                    from include/net/sock.h:59,
                    from include/linux/tcp.h:19,
                    from include/linux/ipv6.h:87,
                    from net///9p/trans_virtio.c:19:
   include/net/netlink.h: In function 'nla_get_in6_addr':
>> include/net/netlink.h:1636:9: warning: missing braces around initializer [-Wmissing-braces]
     struct in6_addr tmp = { 0 };
            ^
   include/net/netlink.h:1636:9: warning: (near initialization for 'tmp.in6_u') [-Wmissing-braces]

vim +1636 include/net/netlink.h

  1629	
  1630	/**
  1631	 * nla_get_in6_addr - return payload of IPv6 address attribute
  1632	 * @nla: IPv6 address netlink attribute
  1633	 */
  1634	static inline struct in6_addr nla_get_in6_addr(const struct nlattr *nla)
  1635	{
> 1636		struct in6_addr tmp = { 0 };
  1637	
  1638		if (nla)
  1639			nla_memcpy(&tmp, nla, sizeof(tmp));
  1640	
  1641		return tmp;
  1642	}
  1643	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (34174 bytes)