netdev - Re: [PATCH v4 06/17] octeontx2-pf: Receive packet handling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200124101416.GA33242@ranger.igk.intel.com>
Date:   Fri, 24 Jan 2020 11:14:16 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kubakici@...pl,
        mkubecek@...e.cz, Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH v4 06/17] octeontx2-pf: Receive packet handling support

On Tue, Jan 21, 2020 at 06:51:40PM +0530, sunil.kovvuri@...il.com wrote:
> From: Sunil Goutham <sgoutham@...vell.com>
> 
> Added receive packet handling (NAPI) support, error stats, RX_ALL
> capability config option to passon error pkts to stack upon user request.
> 
> In subsequent patches these error stats will be added to ethttool.
> 
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> ---
>  .../ethernet/marvell/octeontx2/nic/otx2_common.c   |   2 +
>  .../ethernet/marvell/octeontx2/nic/otx2_common.h   |  44 +++++
>  .../net/ethernet/marvell/octeontx2/nic/otx2_pf.c   |  16 +-
>  .../ethernet/marvell/octeontx2/nic/otx2_struct.h   | 195 +++++++++++++++++++++
>  .../net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 185 ++++++++++++++++++-
>  .../net/ethernet/marvell/octeontx2/nic/otx2_txrx.h |   2 +
>  6 files changed, 441 insertions(+), 3 deletions(-)
> 
<snip>

> +static void otx2_skb_add_frag(struct otx2_nic *pfvf, struct sk_buff *skb,
> +			      u64 iova, int len, struct nix_rx_parse_s *parse)

Nit: 'parse' is unused in this function.

> +{
> +	struct page *page;
> +	void *va;
> +
> +	va = phys_to_virt(otx2_iova_to_phys(pfvf->iommu_domain, iova));
> +	page = virt_to_page(va);
> +	skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, page,
> +			va - page_address(page), len, pfvf->rbsize);
> +
> +	otx2_dma_unmap_page(pfvf, iova - OTX2_HEAD_ROOM,
> +			    pfvf->rbsize, DMA_FROM_DEVICE);
> +}

<snip>