netdev - Re: [PATCH mlx5-next] IB/mlx5: Return the administrative GUID if exists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200125190449.GA30147@jggl>
Date:   Sat, 25 Jan 2020 15:04:49 -0400
From:   Jason <jgg@...pe.ca>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Danit Goldberg <danitg@...lanox.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        linux-netdev <netdev@...r.kernel.org>,
        Leon Romanovsky <leonro@...lanox.com>
Subject: Re: [PATCH mlx5-next] IB/mlx5: Return the administrative GUID if
 exists

On Thu, Jan 16, 2020 at 02:00:48PM +0200, Leon Romanovsky wrote:
> From: Danit Goldberg <danitg@...lanox.com>
> 
> A user can achieve the operational GUID (a.k.a affective GUID) through
> link/infiniband. Therefore it is preferred to return the administrative
> GUID if exists instead of the operational.
> This way the PF can query which VF GUID will be set in the next bind.
> In order to align with MAC address, zero is returned if
> administrative GUID is not set.
> 
> For example:
> - Before setting administrative GUID:
> ip link show
> ib0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 4092 qdisc mq state UP mode DEFAULT group default qlen 256
> link/infiniband 00:00:00:08:fe:80:00:00:00:00:00:00:52:54:00:c0:fe:12:34:55 brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
> vf 0     link/infiniband 00:00:00:08:fe:80:00:00:00:00:00:00:52:54:00:c0:fe:12:34:55 brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff,
> spoof checking off, NODE_GUID 00:00:00:00:00:00:00:00, PORT_GUID 00:00:00:00:00:00:00:00, link-state auto, trust off, query_rss off
> 
> ip link set ib0 vf 0 node_guid 11:00:af:21:cb:05:11:00
> ip link set ib0 vf 0 port_guid 22:11:af:21:cb:05:11:00
> 
> - After setting administrative GUID:
> ip link show
> ib0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 4092 qdisc mq state UP mode DEFAULT group default qlen 256
> link/infiniband 00:00:00:08:fe:80:00:00:00:00:00:00:52:54:00:c0:fe:12:34:55 brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff
> vf 0     link/infiniband 00:00:00:08:fe:80:00:00:00:00:00:00:52:54:00:c0:fe:12:34:55 brd 00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:ff:ff:ff:ff,
> spoof checking off, NODE_GUID 11:00:af:21:cb:05:11:00, PORT_GUID 22:11:af:21:cb:05:11:00, link-state auto, trust off, query_rss off
> 
> Fixes: 9c0015ef0928 ("IB/mlx5: Implement callbacks for getting VFs GUID attributes")
> Signed-off-by: Danit Goldberg <danitg@...lanox.com>
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
> ---
>  drivers/infiniband/hw/mlx5/ib_virt.c | 28 ++++++++++++----------------
>  include/linux/mlx5/driver.h          |  5 +++++
>  2 files changed, 17 insertions(+), 16 deletions(-)

Applied to for-next, thanks

Jason