netdev - Re: [PATCH net-next 2/2] mptcp: Fix code formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200125.081501.844064409437176102.davem@davemloft.net>
Date:   Sat, 25 Jan 2020 08:15:01 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     mathew.j.martineau@...ux.intel.com
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org, edumazet@...gle.com
Subject: Re: [PATCH net-next 2/2] mptcp: Fix code formatting

From: Mat Martineau <mathew.j.martineau@...ux.intel.com>
Date: Fri, 24 Jan 2020 16:04:03 -0800

> checkpatch.pl had a few complaints in the last set of MPTCP patches:
> 
> ERROR: code indent should use tabs where possible
> +^I         subflow, sk->sk_family, icsk->icsk_af_ops, target, mapped);$
> 
> CHECK: Comparison to NULL could be written "!new_ctx"
> +	if (new_ctx == NULL) {
> 
> ERROR: "foo * bar" should be "foo *bar"
> +static const struct proto_ops * tcp_proto_ops(struct sock *sk)
> 
> Signed-off-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

Applied.