netdev - Re: [PATCH net-next] soreuseport: Cleanup duplicate initialization of more_reuse->max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Jan 2020 10:29:36 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     kuniyu@...zon.co.jp
Cc:     netdev@...r.kernel.org, kuni1840@...il.com
Subject: Re: [PATCH net-next] soreuseport: Cleanup duplicate initialization
 of more_reuse->max_socks.

From: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
Date: Thu, 23 Jan 2020 15:52:23 +0000

> diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c
> index f19f179538b9..91e9f2223c39 100644
> --- a/net/core/sock_reuseport.c
> +++ b/net/core/sock_reuseport.c
> @@ -107,7 +107,6 @@ static struct sock_reuseport *reuseport_grow(struct sock_reuseport *reuse)
> 	if (!more_reuse)
> 		return NULL;
> -	more_reuse->max_socks = more_socks_size;
> 	more_reuse->num_socks = reuse->num_socks;
> 	more_reuse->prog = reuse->prog;
> 	more_reuse->reuseport_id = reuse->reuseport_id;
> --
> 2.17.2

This patch is corrupted.  The context says that there are 7 lines beforehand
and 6 afterwards.  But the hunk shows 6 lines beforehand and 5 afterward.