netdev - Re: [PATCHv4 0/3] bpf: trampoline fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Jan 2020 07:23:21 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Andrii Nakryiko <andriin@...com>,
        Yonghong Song <yhs@...com>, Martin KaFai Lau <kafai@...com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        David Miller <davem@...hat.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCHv4 0/3] bpf: trampoline fixes

On Thu, Jan 23, 2020 at 8:15 AM Jiri Olsa <jolsa@...nel.org> wrote:
>
> hi,
> sending 2 fixes to fix kernel support for loading
> trampoline programs in bcc/bpftrace and allow to
> unwind through trampoline/dispatcher.
>
> Original rfc post [1].
>
> Speedup output of perf bench while running klockstat.py
> on kprobes vs trampolines:
>
>     Without:
>             $ perf bench sched messaging -l 50000
>             ...
>                  Total time: 18.571 [sec]
>
>     With current kprobe tracing:
>             $ perf bench sched messaging -l 50000
>             ...
>                  Total time: 183.395 [sec]
>
>     With kfunc tracing:
>             $ perf bench sched messaging -l 50000
>             ...
>                  Total time: 39.773 [sec]
>
> v4 changes:
>   - rebased on latest bpf-next/master
>   - removed image tree mutex and use trampoline_mutex instead
>   - checking directly for string pointer in patch 1 [Alexei]
>   - skipped helpers patches, as they are no longer needed [Alexei]

Applied. Thanks