lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 27 Jan 2020 02:04:22 +0100
From:   Andrew Lunn <>
To:     Michal Kubecek <>
Cc:     David Miller <>,,
        Jakub Kicinski <>,
        Jiri Pirko <>,
        Florian Fainelli <>,
        John Linville <>,
        Johannes Berg <>,
Subject: Re: [PATCH net-next 3/7] ethtool: set message mask with DEBUG_SET

> +	ret = ethnl_parse_header(&req_info, tb[ETHTOOL_A_DEBUG_HEADER],
> +				 genl_info_net(info), info->extack, true);

> +	dev_put(dev);

Hi Michal

While reviewing this patch i noticed this dev_put() and wondered where
the dev_get() was. It is hiding inside ethnl_parse_header(). The
documentation does make it clear it takes a reference on the device,
but how many people read the documentation? I would not be too
surprised if at some point in the future we have bugs from missing

Could we make this a bit more explicit by calling it
ethnl_parse_header_dev_get(). It is rather long though.


Powered by blists - more mailing lists