netdev - Re: [PATCH net-next] net/core: Replace driver version to be kernel version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Jan 2020 14:42:05 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     David Miller <davem@...emloft.net>
Cc:     kuba@...nel.org, snelson@...sando.io, michal.kalderon@...vell.com,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next] net/core: Replace driver version to be kernel
 version

On Mon, Jan 27, 2020 at 01:21:14PM +0100, David Miller wrote:
> From: Leon Romanovsky <leon@...nel.org>
> Date: Mon, 27 Jan 2020 07:49:55 +0200
>
> > We, RDMA and many other subsystems mentioned in that ksummit thread,
> > removed MODULE_VERSION() a long time ago and got zero complains from
> > the real users.
>
> Changes to RDMA have a disproportionate level of impact compared to
> all of netdev.
>
> So comparing the level of real or perceived potential impact is quite
> intellectually dishonest.

This whole discussion was more emotional than intellectual :).

Anyway, I sent v4 https://lore.kernel.org/linux-rdma/20200127072028.19123-1-leon@kernel.org
and that variant provides default version value without harming
out-of-tree modules.

I have a plan to start and remove ethtool version and MODULE_VERSION()
calls from the drivers/net/* modules after merge window completes.

Does this plan sound right to you?

Thanks