netdev - Re: [PATCH] net/802/mrp: disconnect on uninit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200127.104729.424111923374196200.davem@davemloft.net>
Date:   Mon, 27 Jan 2020 10:47:29 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     syzbot+5cfab121b54dff775399@...kaller.appspotmail.com,
        allison@...utok.net, keescook@...omium.org,
        kstewart@...uxfoundation.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, pankaj.laxminarayan.bharadiya@...el.com,
        syzkaller-bugs@...glegroups.com, tglx@...utronix.de
Subject: Re: [PATCH] net/802/mrp: disconnect on uninit

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 22 Jan 2020 10:26:04 +0300

> [  I was investigating this bug and I sort of got carried away and wrote
>    a patch.  I'm going to see if I can find a test system to start
>    testing these patches then I will resend the patch.  - dan ]
> 
> Syzbot discovered that mrp_attr attr structs are being leaked.  They're
> supposed to be freed by mrp_attr_destroy() which is called from
> mrp_attr_event().
> 
> I think that when we close everything down, we're supposed to send one
> last disconnect event but the code for that wasn't fully implemented.
> 
> Reported-by: syzbot+5cfab121b54dff775399@...kaller.appspotmail.com
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> Not tested.  Idea only.

Yes, please resend this when it is tested, somehow, by someone :-)