netdev - Re: [PATCH net] net_sched: ematch: reject invalid TCF_EM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200127.105607.566168953084755587.davem@davemloft.net>
Date:   Mon, 27 Jan 2020 10:56:07 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzbot+03c4738ed29d5d366ddf@...kaller.appspotmail.com,
        xiyou.wangcong@...il.com
Subject: Re: [PATCH net] net_sched: ematch: reject invalid TCF_EM_SIMPLE

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 24 Jan 2020 14:57:20 -0800

> It is possible for malicious userspace to set TCF_EM_SIMPLE bit
> even for matches that should not have this bit set.
> 
> This can fool two places using tcf_em_is_simple()
> 
> 1) tcf_em_tree_destroy() -> memory leak of em->data
>    if ops->destroy() is NULL
> 
> 2) tcf_em_tree_dump() wrongly report/leak 4 low-order bytes
>    of a kernel pointer.
> 
> BUG: memory leak
 ...
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot+03c4738ed29d5d366ddf@...kaller.appspotmail.com
> Cc: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks Eric.