netdev - Re: [PATCH bpf-next v3 0/3] XDP flush cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33363fbd-44e3-bffe-421c-367207db30c2@iogearbox.net>
Date:   Mon, 27 Jan 2020 11:58:39 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     John Fastabend <john.fastabend@...il.com>, bpf@...r.kernel.org
Cc:     bjorn.topel@...el.com, songliubraving@...com, ast@...nel.org,
        toke@...hat.com, maciej.fijalkowski@...el.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v3 0/3] XDP flush cleanups

On 1/27/20 1:13 AM, John Fastabend wrote:
> A couple updates to cleanup some of the XDP comments and rcu usage.
> 
> It would be best if patch 1/3 goes into current bpf-next with the
> associated patch in the fixes tag so we don't have out of sync
> comments in the code. Just noting because its close to time to close
> {bpf|net}-next branches.
> 
> v2->v3: Jesper noticed I can't spell, so fixed spelling. If we
> are fixing comments its best to have correct spelling.
> 
> v1->v2: Added 2/3 patch for virtio_net to use rcu_access_pointer
> and avoid read_lock.
> 
> John Fastabend (3):
>    bpf: xdp, update devmap comments to reflect napi/rcu usage
>    bpf: xdp, virtio_net use access ptr macro for xdp enable check
>    bpf: xdp, remove no longer required rcu_read_{un}lock()
> 
>   drivers/net/veth.c       |  6 +++++-
>   drivers/net/virtio_net.c |  2 +-
>   kernel/bpf/devmap.c      | 26 ++++++++++++++------------
>   3 files changed, 20 insertions(+), 14 deletions(-)
> 

Series applied, thanks. I had to manually massage the patch 3/3 as it
wasn't rebased onto bpf-next.