netdev - Re: [PATCH net v2 3/6] netdevsim: fix stack-out-of-bounds in nsim_dev_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200127200445.760e34ee@cakuba>
Date:   Mon, 27 Jan 2020 20:04:45 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Taehee Yoo <ap420073@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net v2 3/6] netdevsim: fix stack-out-of-bounds in
 nsim_dev_debugfs_init()

On Mon, 27 Jan 2020 14:30:34 +0000, Taehee Yoo wrote:
> When netdevsim dev is being created, a debugfs directory is created.
> The variable "dev_ddir_name" is 16bytes device name pointer and device
> name is "netdevsim<dev id>".
> The maximum dev id length is 10.
> So, 16bytes for device name isn't enough.

> Fixes: ab1d0cc004d7 ("netdevsim: change debugfs tree topology")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>