netdev - Re: [netfilter-core] INFO: rcu detected stall in hash_ip4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.2001280948480.5190@blackhole.kfki.hu>
Date:   Tue, 28 Jan 2020 09:53:45 +0100 (CET)
From:   Kadlecsik József <kadlec@...ckhole.kfki.hu>
To:     Hillf Danton <hdanton@...a.com>
cc:     syzbot <syzbot+68a806795ac89df3aa1c@...kaller.appspotmail.com>,
        x86@...nel.org, tony.luck@...el.com, peterz@...radead.org,
        netdev@...r.kernel.org, hpa@...or.com,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        coreteam@...filter.org, bp@...en8.de,
        netfilter-devel@...r.kernel.org, tglx@...utronix.de,
        mingo@...hat.com, davem@...emloft.net
Subject: Re: [netfilter-core] INFO: rcu detected stall in hash_ip4_gc

On Tue, 28 Jan 2020, Hillf Danton wrote:

> 
> On Mon, 27 Jan 2020 23:14:03 +0100 (CET) Kadlecsik Jozsef wrote:
> > 
> > Thanks for the patch, but it does not fix completely the issue: the same 
> > error message can pop up in ip_set_uadd(), because it calls the gc 
> > function as well when the set is full but there can be timed out entries. 
> 
> Why is trylock-based gc going to make hassle again?

Because mtype_expire() which scans the whole set to find and evict 
expired entries is called not only from the gc function but from add as 
well (to reclaim space since last gc) and list too (to get the number of 
elements). One locks out the another and that reported in the error 
message.

> > I'm going to work on a solution with covers that case too.

Region-locking seems to be the best way to go.

Best regards,
Jozsef
-
E-mail  : kadlec@...ckhole.kfki.hu, kadlecsik.jozsef@...ner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics
          H-1525 Budapest 114, POB. 49, Hungary