netdev - Re: [PATCH] mptcp: Fix incorrect IPV6 dependency check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.21.2001291308450.9282@cmossx-mobl1.amr.corp.intel.com>
Date:   Wed, 29 Jan 2020 13:10:04 -0800 (PST)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
cc:     Paolo Abeni <pabeni@...hat.com>, Florian Westphal <fw@...len.de>,
        Christoph Paasch <cpaasch@...le.com>,
        Matthieu Baerts <matthieu.baerts@...sares.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        mptcp@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mptcp: Fix incorrect IPV6 dependency check

On Wed, 29 Jan 2020, Geert Uytterhoeven wrote:

> If CONFIG_MPTCP=y, CONFIG_MPTCP_IPV6=n, and CONFIG_IPV6=m:
>
>    net/mptcp/protocol.o: In function `__mptcp_tcp_fallback':
>    protocol.c:(.text+0x786): undefined reference to `inet6_stream_ops'
>
> Fix this by checking for CONFIG_MPTCP_IPV6 instead of CONFIG_IPV6, like
> is done in all other places in the mptcp code.
>
> Fixes: 8ab183deb26a3b79 ("mptcp: cope with later TCP fallback")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>


--
Mat Martineau
Intel