netdev - Re: [PATCH net v2 2/3] taprio: Allow users not to specify "flags" when changing schedules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200129.111245.1611718557356636170.davem@davemloft.net>
Date:   Wed, 29 Jan 2020 11:12:45 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     vinicius.gomes@...el.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, vladimir.oltean@....com, po.liu@....com
Subject: Re: [PATCH net v2 2/3] taprio: Allow users not to specify "flags"
 when changing schedules

From: Vinicius Costa Gomes <vinicius.gomes@...el.com>
Date: Tue, 28 Jan 2020 15:52:26 -0800

> When any offload mode is enabled, users had to specify the
> "flags" parameter when adding a new "admin" schedule.
> 
> This fix allows that parameter to be omitted when adding a new
> schedule.
> 
> This will make that we have one source of truth for 'flags'.
> 
> Fixes: 4cfd5779bd6e ("taprio: Add support for txtime-assist mode")
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> Acked-by: Vladimir Oltean <vladimir.oltean@....com>

This will visibly change behavior for a feature in a released
kernel (v5.3 and later) and it means that newer tools will do
things that don't work in older kernels.

I think your opportunity to adjust these semantics, has therefore,
long passed.

Sorry.