netdev - Re: [PATCH net] phy: avoid unnecessary link-up delay in polling mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48acf1493888ea4084d9a9e75dc05c32e9e32fc9.camel@redhat.com>
Date:   Wed, 29 Jan 2020 13:23:25 +0100
From:   Petr Oros <poros@...hat.com>
To:     David Miller <davem@...emloft.net>, ivecera@...hat.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com,
        hkallweit1@...il.com
Subject: Re: [PATCH net] phy: avoid unnecessary link-up delay in polling mode

David Miller píše v St 29. 01. 2020 v 13:15 +0100:
> From: Ivan Vecera <ivecera@...hat.com>
> Date: Wed, 29 Jan 2020 13:06:22 +0100
> 
> > On Wed, 29 Jan 2020 11:13:08 +0100
> > Petr Oros <poros@...hat.com> wrote:
> > 
> >> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> >> index 6a5056e0ae7757..d5f4804c34d597 100644
> >> --- a/drivers/net/phy/phy_device.c
> >> +++ b/drivers/net/phy/phy_device.c
> >> @@ -1930,9 +1930,10 @@ int genphy_update_link(struct phy_device *phydev)
> >>  
> >>      /* The link state is latched low so that momentary link
> >>       * drops can be detected. Do not double-read the status
> >> -     * in polling mode to detect such short link drops.
> >> +     * in polling mode to detect such short link drops except
> >> +     * the link was already down.
> >>       */
> >> -    if (!phy_polling_mode(phydev)) {
> >> +    if (!phy_polling_mode(pihydev) || !phydev->link) {
> >                                ^
> > Please remove the extra 'i' ----
> 
> How could this have ever been even build tested, let alone functionally
> tested? :-/

Sorry, it was tested on xgene-enet with RTL8211E phy. With patch there was ~4s
delay and without it ~5s. But before send i added "except the link was already
down" comment and by mistake added extra "i" in vim. Again, sorry.

-Petr

>