netdev - Re: [RFC PATCH 00/13] devlink direct region reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 30 Jan 2020 15:03:37 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     netdev@...r.kernel.org
Cc:     jiri@...nulli.us, valex@...lanox.com, linyunsheng@...wei.com,
        lihong.yang@...el.com
Subject: Re: [RFC PATCH 00/13] devlink direct region reading



On 1/30/2020 2:58 PM, Jacob Keller wrote:
> 
> Jacob Keller (12):
>   devlink: prepare to support region operations
>   devlink: add functions to take snapshot while locked
>   devlink: add operation to take an immediate snapshot
>   netdevsim: support taking immediate snapshot via devlink
>   ice: use __le16 types for explicitly Little Endian values
>   ice: create function to read a section of the NVM and Shadow RAM
>   ice: enable initial devlink support for function zero
>   ice: add basic handler for devlink .info_get
>   ice: add board identifier info to devlink .info_get
>   ice: add a devlink region to dump shadow RAM contents
>   devlink: support directly reading from region memory
>   ice: support direct read of the shadow ram region
> 
> Jesse Brandeburg (1):
>   ice: implement full NVM read from ETHTOOL_GEEPROM
> 
>  drivers/net/ethernet/intel/Kconfig            |   1 +
>  drivers/net/ethernet/intel/ice/Makefile       |   1 +
>  drivers/net/ethernet/intel/ice/ice.h          |   7 +
>  .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   3 +
>  drivers/net/ethernet/intel/ice/ice_common.c   |  61 +++
>  drivers/net/ethernet/intel/ice/ice_common.h   |   5 +-
>  drivers/net/ethernet/intel/ice/ice_devlink.c  | 427 ++++++++++++++++++
>  drivers/net/ethernet/intel/ice/ice_devlink.h  |  20 +
>  drivers/net/ethernet/intel/ice/ice_ethtool.c  |  37 +-
>  drivers/net/ethernet/intel/ice/ice_main.c     |  22 +
>  drivers/net/ethernet/intel/ice/ice_nvm.c      | 211 +++------
>  drivers/net/ethernet/intel/ice/ice_nvm.h      |   7 +
>  drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
>  drivers/net/ethernet/mellanox/mlx4/crdump.c   |  25 +-
>  drivers/net/netdevsim/dev.c                   |  44 +-
>  include/net/devlink.h                         |  28 +-
>  include/uapi/linux/devlink.h                  |   2 +
>  net/core/devlink.c                            | 246 +++++++---
>  18 files changed, 918 insertions(+), 230 deletions(-)
>  create mode 100644 drivers/net/ethernet/intel/ice/ice_devlink.c
>  create mode 100644 drivers/net/ethernet/intel/ice/ice_devlink.h
> 

Woops, I forgot to re-create the cover letter after some reworks. All of
the following patches should have also been tagged with 'RFC'. Here's
the correct cover letter summary for this:

> 
> Jacob Keller (14):
>   devlink: prepare to support region operations
>   devlink: add functions to take snapshot while locked
>   devlink: add operation to take an immediate snapshot
>   netdevsim: support taking immediate snapshot via devlink
>   ice: use __le16 types for explicitly Little Endian values
>   ice: create function to read a section of the NVM and Shadow RAM
>   devlink: add devres managed devlinkm_alloc and devlinkm_free
>   ice: enable initial devlink support
>   ice: add basic handler for devlink .info_get
>   ice: add board identifier info to devlink .info_get
>   ice: add a devlink region to dump shadow RAM contents
>   devlink: support directly reading from region memory
>   ice: support direct read of the shadow ram region
>   ice: add ice.rst devlink documentation file
> 
> Jesse Brandeburg (1):
>   ice: implement full NVM read from ETHTOOL_GEEPROM
> 
>  .../networking/devlink/devlink-region.rst     |  17 +-
>  Documentation/networking/devlink/ice.rst      |  76 ++++
>  Documentation/networking/devlink/index.rst    |   1 +
>  drivers/net/ethernet/intel/Kconfig            |   1 +
>  drivers/net/ethernet/intel/ice/Makefile       |   1 +
>  drivers/net/ethernet/intel/ice/ice.h          |   6 +
>  .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   3 +
>  drivers/net/ethernet/intel/ice/ice_common.c   |  66 ----
>  drivers/net/ethernet/intel/ice/ice_common.h   |   6 -
>  drivers/net/ethernet/intel/ice/ice_devlink.c  | 373 ++++++++++++++++++
>  drivers/net/ethernet/intel/ice/ice_devlink.h  |  17 +
>  drivers/net/ethernet/intel/ice/ice_ethtool.c  |  36 +-
>  drivers/net/ethernet/intel/ice/ice_main.c     |  30 +-
>  drivers/net/ethernet/intel/ice/ice_nvm.c      | 340 +++++++++-------
>  drivers/net/ethernet/intel/ice/ice_nvm.h      |  12 +
>  drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
>  drivers/net/ethernet/mellanox/mlx4/crdump.c   |  25 +-
>  drivers/net/netdevsim/dev.c                   |  44 ++-
>  include/net/devlink.h                         |  32 +-
>  include/uapi/linux/devlink.h                  |   2 +
>  lib/devres.c                                  |   1 +
>  net/core/devlink.c                            | 300 +++++++++++---
>  .../drivers/net/netdevsim/devlink.sh          |   5 +
>  23 files changed, 1091 insertions(+), 304 deletions(-)
>  create mode 100644 Documentation/networking/devlink/ice.rst
>  create mode 100644 drivers/net/ethernet/intel/ice/ice_devlink.c
>  create mode 100644 drivers/net/ethernet/intel/ice/ice_devlink.h
> 

Thanks,
Jake