netdev - Re: [PATCH net] udp: document udp_rcv_segment special case for looped packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200130.100011.1303339090607584614.davem@davemloft.net>
Date:   Thu, 30 Jan 2020 10:00:11 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, pabeni@...hat.com, willemb@...gle.com
Subject: Re: [PATCH net] udp: document udp_rcv_segment special case for
 looped packets

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Wed, 29 Jan 2020 15:20:17 -0500

> From: Willem de Bruijn <willemb@...gle.com>
> 
> Commit 6cd021a58c18a ("udp: segment looped gso packets correctly")
> fixes an issue with rare udp gso multicast packets looped onto the
> receive path.
> 
> The stable backport makes the narrowest change to target only these
> packets, when needed. As opposed to, say, expanding __udp_gso_segment,
> which is harder to reason to be free from unintended side-effects.
> 
> But the resulting code is hardly self-describing.
> Document its purpose and rationale.
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied, thanks for following up on this Willem.