netdev - Re: [PATCH] mptcp: Fix undefined mptcp_handle_ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Jan 2020 10:56:23 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     geert@...ux-m68k.org
Cc:     peter.krystad@...ux.intel.com, pabeni@...hat.com, fw@...len.de,
        cpaasch@...le.com, mathew.j.martineau@...ux.intel.com,
        matthieu.baerts@...sares.net, kuba@...nel.org,
        netdev@...r.kernel.org, mptcp@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mptcp: Fix undefined mptcp_handle_ipv6_mapped for
 modular IPV6

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Thu, 30 Jan 2020 10:45:26 +0100

> If CONFIG_MPTCP=y, CONFIG_MPTCP_IPV6=n, and CONFIG_IPV6=m:
> 
>     ERROR: "mptcp_handle_ipv6_mapped" [net/ipv6/ipv6.ko] undefined!
> 
> This does not happen if CONFIG_MPTCP_IPV6=y, as CONFIG_MPTCP_IPV6
> selects CONFIG_IPV6, and thus forces CONFIG_IPV6 builtin.
> 
> As exporting a symbol for an empty function would be a bit wasteful, fix
> this by providing a dummy version of mptcp_handle_ipv6_mapped() for the
> CONFIG_MPTCP_IPV6=n case.
> 
> Rename mptcp_handle_ipv6_mapped() to mptcpv6_handle_mapped(), to make it
> clear this is a pure-IPV6 function, just like mptcpv6_init().
> 
> Fixes: cec37a6e41aae7bf ("mptcp: Handle MP_CAPABLE options for outgoing connections")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Looks good, applied, thank you.