Message-ID: <20200130215330.f3unziderf5rlipf@ast-mbp>
Date:   Thu, 30 Jan 2020 13:53:31 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Matt Cover <werekraken@...il.com>
Cc:     daniel@...earbox.net, davem@...emloft.net,
        Matthew Cover <matthew.cover@...ckpath.com>,
        netdev@...r.kernel.org, bpf@...r.kernel.org, kernel-team@...com
Subject: unstable bpf helpers proposal. Was: [PATCH bpf-next v2 1/2] bpf: add
 bpf_ct_lookup_{tcp,udp}() helpers

On Fri, Jan 24, 2020 at 02:46:30PM -0700, Matt Cover wrote:
> 
> In addition to the nf_conntrack helpers, I'm hoping to add helpers for
> lookups to the ipvs connection table via ip_vs_conn_in_get(). From my
> perspective, this is again similar. 

...

> Writing to an existing nf_conn could be added to this helper in the
> future. Then, as an example, an XDP program could populate ct->mark
> and a restore mark rule could be used to apply the mark to the skb.
> This is conceptually similar to the XDP/tc interaction example.

...

> I'm planning to add a bpf_tcp_nf_conn() helper which gives access to
> members of ip_ct_tcp. This is similar to bpf_tcp_sock() in my mind.

...

> I touched on create and update above. Delete, like create, would
> almost certainly be a separate helper. This submission is not
> intended to put us on that track. I do not believe it hinders an
> effort such as that either. Are you worried that adding nf_conn to
> bpf is a slippery slope?

Looks like there is a need to access quite a bit of ct, ipvs internal states.
I bet neigh, route and other kernel internal tables will be next. The
lookup/update/delete to these tables is necessary. If somebody wants to do a
fast bridge in XDP they may want to reuse icmp_send(). I've seen folks
reimplementing it purely on BPF side, but kernel's icmp_send() is clearly
superior, so exposing it as a helper will be useful too. And so on and so
forth. There are lots of kernel bits that BPF progs want to interact with.

If we expose all of that via existing bpf helper mechanism we will freeze a
large chunk of networking stack. I agree that accessing these data structures
from BPF side is useful, but I don't think we can risk hardening the kernel so
much. We need new helper mechanism that will be unstable api. It needs to be
obviously unstable to both kernel developers and bpf users. Yet such mechanim
should allow bpf progs accessing all these things without sacrificing safety.

I think such new mechanism can be modeled similar to kernel modules and
EXPORT_SYMBOL[_GPL] convention. The kernel has established policy that
these function do change and in-tree kernel modules get updated along the way
while out-of-tree gets broken periodically. I propose to do the same for BPF.
Certain kernel functions can be marked as EXPORT_SYMBOL_BPF and they will be
eligible to be called from BPF program. The verifier will do safety checks and
type matching based on BTF. The same way it already does for tracing progs.
For example the ct lookup can be:
struct nf_conn *
bpf_ct_lookup(struct __sk_buff *skb, struct nf_conntrack_tuple *tuple, u32 len,
              u8 proto, u64 netns_id, u64 flags)
{
}
EXPORT_SYMBOL_BPF(bpf_ct_lookup);
The first argument 'skb' has stable api and type. It's __sk_buff and it's
context for all skb-based progs, so any program that got __sk_buff from
somewhere can pass it into this helper.
The second argument is 'struct nf_conntrack_tuple *'. It's unstable and
kernel internal. Currently the verifier recognizes it as PTR_TO_BTF_ID
for tracing progs and can do the same for networking. It cannot recognize
it on stack though. Like:
int bpf_prog(struct __sk_buff *skb)
{
  struct nf_conntrack_tuple my_tupple = { ...};
  bpf_ct_lookup(skb, &my_tupple, ...);
}
won't work yet. The verifier needs to be taught to deal with PTR_TO_BTF_ID
where it points to the stack.
The last three arguments are scalars and already recognized as SCALAR_VALUE by
the verifier. So with minor extensions the verifier will be able to prove the
safety of argument passing.

The return value is trickier. It can be solved with appropriate type
annotations like:
struct nf_conn *
bpf_ct_lookup(struct __sk_buff *skb, struct nf_conntrack_tuple *tuple, u32 len,
             u8 proto, u64 netns_id, u64 flags)
{ ...
}
EXPORT_SYMBOL_BPF__acquires(bpf_ct_lookup);
int bpf_ct_release(struct nf_conn * ct)
{ ...
}
EXPORT_SYMBOL_BPF__releases(bpf_ct_release);
By convention the return value is acquired and the first argument is released.
Then the verifier will be able to pair them the same way it does
bpf_sk_lookup()/bpf_sk_release(), but in declarative way. So the verifier code
doesn't need to be touched for every such function pair in the future.

Note struct nf_conn and struct nf_conntrack_tuple stay kernel internal.
BPF program can define fields it wants to access as:
struct nf_conn {
  u32 timeout;
  u64 status;
  u32 mark;
} __attribute__((preserve_access_index));
int bpf_prog()
{
  struct nf_conn *ct = bpf_ct_lookup(...);
  if (ct) {
       ct->timeout;
  }
}
and CO-RE logic will deal with kernel specific relocations.
The same way it does for tracing progs that access all kernel data.

I think it's plenty obvious that such bpf helpers are unstable api. The
networking programs will have access to all kernel data structures, receive
them from white listed set of EXPORT_SYMBOL_BPF() functions and pass them into
those functions back. Just like tracing progs that have access to everything.
They can read all fields of kernel internal struct sk_buff and pass it into
bpf_skb_output().
The same way kernel modules can access all kernel data structures and call
white listed set of EXPORT_SYMBOL() helpers.

Powered by blists - more mailing lists