netdev - Re: [PATCH net v3 1/2] taprio: Fix enabling offload with wrong number of traffic classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pnezbj55.fsf@linux.intel.com>
Date:   Fri, 31 Jan 2020 10:00:54 -0800
From:   Vinicius Costa Gomes <vinicius.gomes@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, davem@...emloft.net, vladimir.oltean@....com,
        po.liu@....com
Subject: Re: [PATCH net v3 1/2] taprio: Fix enabling offload with wrong number of traffic classes

Jakub Kicinski <kuba@...nel.org> writes:

> On Wed, 29 Jan 2020 17:37:20 -0800, Vinicius Costa Gomes wrote:
>> If the driver implementing taprio offloading depends on the value of
>> the network device number of traffic classes (dev->num_tc) for
>> whatever reason, it was going to receive the value zero. The value was
>> only set after the offloading function is called.
>> 
>> So, moving setting the number of traffic classes to before the
>> offloading function is called fixes this issue. This is safe because
>> this only happens when taprio is instantiated (we don't allow this
>> configuration to be changed without first removing taprio).
>> 
>> Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading")
>> Reported-by: Po Liu <po.liu@....com>
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
>> Acked-by: Vladimir Oltean <vladimir.oltean@....com>
>
> What about Dave's question about resetting the tc state with
> netdev_reset_tc()?

I missed that question.