[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <05e21ed9-d5af-b57c-36cd-50b34915e82d@infradead.org>
Date: Thu, 30 Jan 2020 21:12:57 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Tiwei Bie <tiwei.bie@...el.com>, mst@...hat.com,
jasowang@...hat.com
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
shahafs@...lanox.com, jgg@...lanox.com, rob.miller@...adcom.com,
haotian.wang@...ive.com, eperezma@...hat.com, lulu@...hat.com,
parav@...lanox.com, hch@...radead.org, jiri@...lanox.com,
hanand@...inx.com, mhabets@...arflare.com,
maxime.coquelin@...hat.com, lingshan.zhu@...el.com,
dan.daly@...el.com, cunming.liang@...el.com, zhihong.wang@...el.com
Subject: Re: [PATCH] vhost: introduce vDPA based backend
On 1/30/20 7:56 PM, Randy Dunlap wrote:
> Hi,
>
> On 1/30/20 7:36 PM, Tiwei Bie wrote:
>> diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
>> index f21c45aa5e07..13e6a94d0243 100644
>> --- a/drivers/vhost/Kconfig
>> +++ b/drivers/vhost/Kconfig
>> @@ -34,6 +34,18 @@ config VHOST_VSOCK
>> To compile this driver as a module, choose M here: the module will be called
>> vhost_vsock.
>>
>> +config VHOST_VDPA
>> + tristate "Vhost driver for vDPA based backend"
oops, missed this one:
vDPA-based
>> + depends on EVENTFD && VDPA
>> + select VHOST
>> + default n
>> + ---help---
>> + This kernel module can be loaded in host kernel to accelerate
>> + guest virtio devices with the vDPA based backends.
>
> vDPA-based
>
>> +
>> + To compile this driver as a module, choose M here: the module
>> + will be called vhost_vdpa.
>> +
>
> The preferred Kconfig style nowadays is
> (a) use "help" instead of "---help---"
> (b) indent the help text with one tab + 2 spaces
>
> and don't use "default n" since that is already the default.
>
>> config VHOST
>> tristate
>> depends on VHOST_IOTLB
>
> thanks.
>
--
~Randy
Powered by blists - more mailing lists