netdev - Re: [PATCH net] netfilter: nf_flowtable: fix documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGnkfhzHqHFiqje3_ruSFvz09QKv3M8dqvOqzN_kau6ZpKzWOw@mail.gmail.com>
Date:   Fri, 31 Jan 2020 01:23:56 +0100
From:   Matteo Croce <mcroce@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>, netfilter-devel@...r.kernel.org
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        netdev <netdev@...r.kernel.org>, linux-doc@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Florian Westphal <fw@...len.de>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] netfilter: nf_flowtable: fix documentation

On Thu, Jan 30, 2020 at 11:14 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 30 Jan 2020 20:10:19 +0100, Matteo Croce wrote:
> > In the flowtable documentation there is a missing semicolon, the command
> > as is would give this error:
> >
> >     nftables.conf:5:27-33: Error: syntax error, unexpected devices, expecting newline or semicolon
> >                     hook ingress priority 0 devices = { br0, pppoe-data };
> >                                             ^^^^^^^
> >     nftables.conf:4:12-13: Error: invalid hook (null)
> >             flowtable ft {
> >                       ^^
> >
> > Fixes: 19b351f16fd9 ("netfilter: add flowtable documentation")
> > Signed-off-by: Matteo Croce <mcroce@...hat.com>
>
> This is netfilter so even though it's tagged as net, I'm expecting
> Pablo (or Jon) to take it. Please LMK if I'm wrong.
>

You're right.
As get_maintainers.pl didn't list netfilter-devel@...r.kernel.org I missed it.

-- 
Matteo Croce
per aspera ad upstream