netdev - Re: [PATCH 4/6] net: bcmgenet: Initial bcmgenet ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0536fbdc-f118-3165-9e63-913c1d0def9d@arm.com>
Date:   Sat, 1 Feb 2020 13:09:02 -0600
From:   Jeremy Linton <jeremy.linton@....com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, opendmb@...il.com, f.fainelli@...il.com,
        davem@...emloft.net, bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, wahrenst@....net,
        hkallweit1@...il.com
Subject: Re: [PATCH 4/6] net: bcmgenet: Initial bcmgenet ACPI support

Hi,

On 2/1/20 9:33 AM, Andrew Lunn wrote:
>> @@ -3595,7 +3597,7 @@ static int bcmgenet_probe(struct platform_device *pdev)
>>   	/* If this is an internal GPHY, power it on now, before UniMAC is
>>   	 * brought out of reset as absolutely no UniMAC activity is allowed
>>   	 */
>> -	if (dn && !of_property_read_string(dn, "phy-mode", &phy_mode_str) &&
>> +	if (!device_property_read_string(&pdev->dev, "phy-mode", &phy_mode_str) &&
>>   	    !strcasecmp(phy_mode_str, "internal"))
>>   		bcmgenet_power_up(priv, GENET_POWER_PASSIVE);
> 
> The code you are modifying appears to be old and out of date. For a
> long time there has been a helper, of_get_phy_mode(). You should look
> at fwnode_get_phy_mode().

Yes, thanks, I did that in the other phy path but not here.